Skip to content

feat: New rule prefer-called-times #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

feat: New rule prefer-called-times #728

wants to merge 12 commits into from

Conversation

@AntonioVentilii
Copy link
Contributor

@AntonioVentilii AntonioVentilii commented Jun 20, 2025

I would like to propose a new rule prefer-called-once that enforces the use of toBeCalledTimes(1) or toHaveBeenCalledTimes(1) over toBeCalledOnce() or toHaveBeenCalledOnce().

Examples of incorrect code for this rule:

test('foo', () => {
    const mock = vi.fn()
    mock('foo')
    expect(mock).toBeCalledOnce()
    expect(mock).toHaveBeenCalledOnce()
})

Examples of correct code for this rule:

test('foo', () => {
  const mock = vi.fn()
  mock('foo')
  expect(mock).toBeCalledTimes(1)
  expect(mock).toHaveBeenCalledTimes(1)
})

@AntonioVentilii AntonioVentilii changed the title feat: New rule prefer-called-times feat: New rule prefer-called-times Jun 20, 2025
@veritem
Copy link
Member

veritem commented Jun 23, 2025

Totally messed up this pr with documentation tool bug triage. That is on me, your work looks great! Thank you!

@veritem veritem mentioned this pull request Jun 23, 2025
Closed
@AntonioVentilii
Copy link
Contributor Author

AntonioVentilii commented Jun 23, 2025

Thank you @veritem ! For taking care of it

@veritem
Copy link
Member

veritem commented Jun 26, 2025

hey, i made so many experiments in this pr than i should have, sorry about that. i have opened a new pr that includes your work in #733. Once i merge it, it should be released.

@veritem veritem closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AntonioVentilii @veritem